Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the instructions to free up port 53 in Fedora #1660

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Updated the instructions to free up port 53 in Fedora #1660

wants to merge 4 commits into from

Conversation

OptimoSupreme
Copy link

Description

  1. Added a dedicated Fedora section below Ubuntu's since the Ubuntu instructions no longer work on Fedora.
  2. Added 'Debian' to the title of the Ubuntu section since it is applicable there as well.
  3. Fixed the heading level for Ubuntu to match the rest of the readme.

Motivation and Context

This provides Fedora Pihole user with accurate instructions on how to free port 53, which they do not currently have.
Existing Issue.

How Has This Been Tested?

This does not affect any other project code. I have verified that the included commands work as expected on a Fedora 41 server.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

rdwebdesign
rdwebdesign requested changes Nov 16, 2024
View reviewed changes
README.md Show resolved Hide resolved
@OptimoSupreme
Corrected section subtext.
053edc5 
Removed references to Fedora.

Signed-off-by: Justin <[email protected]>
@OptimoSupreme
Reemoved uneeded text.
4654fac 
Signed-off-by: Justin <[email protected]>
yubiuser
yubiuser reviewed Nov 17, 2024
View reviewed changes
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, both sections (Debian/Fedora) should go to https://docs.pi-hole.net/main/prerequisites/

instead. This is not a docker-specific configuration step, but affects bare metal the same way

@rdwebdesign
Copy link
Member

I think, both sections (Debian/Fedora) should go to https://docs.pi-hole.net/main/prerequisites/

I agree.
This README is too long and contains too many details, but not all are directly related to docker.

Maybe the best approach would be to put these 3 items under "Tips and Tricks" with links to external pages:

but we first need to create the pages for the first 2 items in https://docs.pi-hole.net.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser left review comments

@rdwebdesign rdwebdesign Awaiting requested review from rdwebdesign

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OptimoSupreme @rdwebdesign @yubiuser